whimsical-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From s...@apache.org
Subject [whimsy] branch master updated: Better fix for crash
Date Tue, 06 Apr 2021 23:15:05 GMT
This is an automated email from the ASF dual-hosted git repository.

sebb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/whimsy.git


The following commit(s) were added to refs/heads/master by this push:
     new 7173995  Better fix for crash
7173995 is described below

commit 717399528d8f7c549757afdeb62d3c01d56492fb
Author: Sebb <sebb@apache.org>
AuthorDate: Wed Apr 7 00:14:55 2021 +0100

    Better fix for crash
---
 www/roster/models/committee.rb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/www/roster/models/committee.rb b/www/roster/models/committee.rb
index 34d24a8..b4c0df9 100644
--- a/www/roster/models/committee.rb
+++ b/www/roster/models/committee.rb
@@ -58,7 +58,8 @@ class Committee
       info[:role] = 'PMC member'
       next if pmc.ownerids.include?(key) # skip the rest (expensive) if person is in the
owner group
       person = ASF::Person[key]
-      if analysePrivateSubs && person # in case of missing entry (e.g. renamed uid)
+      next unless person  # in case of missing entry (e.g. renamed uid)
+      if analysePrivateSubs
         # Analyse the subscriptions, matching against canonicalised personal emails
         allMail = person.all_mail.map{|m| ASF::Mail.to_canonical(m.downcase)}
         # pSubs is already downcased

Mime
View raw message