ws-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From veit...@apache.org
Subject svn commit: r1293553 - in /webservices/commons/trunk/modules/axiom/modules: axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/ axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/envelope/
Date Sat, 25 Feb 2012 09:20:01 GMT
Author: veithen
Date: Sat Feb 25 09:20:00 2012
New Revision: 1293553

URL: http://svn.apache.org/viewvc?rev=1293553&view=rev
Log:
Implemented a regression test for r631687 (AXIOM-282).

Modified:
    webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMContainerHelper.java
    webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/envelope/TestGetSOAPBodyFirstElementLocalNameAndNSWithParser.java

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMContainerHelper.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMContainerHelper.java?rev=1293553&r1=1293552&r2=1293553&view=diff
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMContainerHelper.java
(original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-impl/src/main/java/org/apache/axiom/om/impl/llom/OMContainerHelper.java
Sat Feb 25 09:20:00 2012
@@ -46,8 +46,6 @@ class OMContainerHelper {
         if (builder != null && builder instanceof StAXOMBuilder) {
             if (!container.isComplete()) {
                 if (((StAXOMBuilder) builder).isLookahead()) {
-                    // TODO: not sure if this is actually still relevant;
-                    //       there is no test case that fails when this is removed
                     container.buildNext();
                 }
             }

Modified: webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/envelope/TestGetSOAPBodyFirstElementLocalNameAndNSWithParser.java
URL: http://svn.apache.org/viewvc/webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/envelope/TestGetSOAPBodyFirstElementLocalNameAndNSWithParser.java?rev=1293553&r1=1293552&r2=1293553&view=diff
==============================================================================
--- webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/envelope/TestGetSOAPBodyFirstElementLocalNameAndNSWithParser.java
(original)
+++ webservices/commons/trunk/modules/axiom/modules/axiom-testsuite/src/main/java/org/apache/axiom/ts/soap/envelope/TestGetSOAPBodyFirstElementLocalNameAndNSWithParser.java
Sat Feb 25 09:20:00 2012
@@ -57,8 +57,10 @@ public class TestGetSOAPBodyFirstElement
         
         // Also request an XMLStreamReader. The LLOM implementation triggers some special
processing
         // in this case (because the getSOAPBodyFirstElementXXX calls put the builder in
lookahead
-        // mode).
-        XMLStreamReader reader = envelope.getBody().getXMLStreamReader();
+        // mode). This is a regression test for r631687 (AXIOM-282).
+        XMLStreamReader reader = envelope.getXMLStreamReader(false);
+        assertEquals(XMLStreamReader.START_ELEMENT, reader.next());
+        assertEquals("Envelope", reader.getLocalName());
         assertEquals(XMLStreamReader.START_ELEMENT, reader.next());
         assertEquals("Body", reader.getLocalName());
         assertEquals(XMLStreamReader.START_ELEMENT, reader.next());



Mime
View raw message